Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deploy jobs from github/workflows/ci.yml #3148

Merged
merged 2 commits into from
Nov 27, 2024
Merged

Remove deploy jobs from github/workflows/ci.yml #3148

merged 2 commits into from
Nov 27, 2024

Conversation

phil-l-brockwell
Copy link
Contributor

@phil-l-brockwell phil-l-brockwell commented Nov 27, 2024 •
edited
Loading

📝 A short description of the changes

  • Disable automatic deploys of main branch to staging and dev environments.
  • Simplify slack notifications
  • Updated Notion docs

🔗 Link to the relevant story (or stories)

:shipit: Deployment implications

✅ Checklist

  • Features that cannot go live are behind a feature flag/env var or specify deploy date and open PR as draft
  • I have checked that commit messages make sense and explain the reasoning for each change
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have squashed any unnecessary or part-finished commits

🖼️ Screenshots (if appropriate - no PII/Prod data):

@phil-l-brockwell phil-l-brockwell marked this pull request as ready for review November 27, 2024 14:30
@phil-l-brockwell phil-l-brockwell force-pushed the pb/remove-auto-deploy-actions-from-ci branch 2 times, most recently from f33b17e to 8579dce Compare November 27, 2024 15:55
@phil-l-brockwell phil-l-brockwell force-pushed the pb/remove-auto-deploy-actions-from-ci branch from 9bb1d2e to ff22c29 Compare November 27, 2024 16:40
@phil-l-brockwell phil-l-brockwell merged commit 2062250 into main Nov 27, 2024
9 checks passed
@phil-l-brockwell phil-l-brockwell deleted the pb/remove-auto-deploy-actions-from-ci branch November 27, 2024 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheDancingClown TheDancingClown TheDancingClown approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@phil-l-brockwell @TheDancingClown