Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pin gha ubuntu base image #1241

Merged
merged 2 commits into from
Dec 17, 2024
Merged

pin gha ubuntu base image #1241

merged 2 commits into from
Dec 17, 2024

Conversation

bjlittle
Copy link
Owner

@bjlittle bjlittle commented Dec 17, 2024

🚀 Pull Request

Description

The default GHA runner latest base image for ubuntu has bumped from 22.04 to 24.04.

This causes issues as the libgl1-mesa-glx APT package is not available and is the source of image tests hanging and/or the GHA cache-apt-pkgs-action to fail.

Adopting best practice advice from the pyvista core developers to pin the base image version and watch the GHA runner-images announcements to migrate (bump base image version) as part of a controlled, rather than unexpected changes through the latest base image label.

Note that, using an explicit GHA base image version is akin to the explicit os version used within the .readthedocs.yml.

Reference actions/runner-images


@github-actions github-actions bot added the type: gha Auto-labelled label Dec 17, 2024
Copy link

codecov bot commented Dec 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.41%. Comparing base (44f26c7) to head (b2c8381).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1241   +/-   ##
=======================================
  Coverage   91.41%   91.41%           
=======================================
  Files          58       58           
  Lines        2959     2959           
=======================================
  Hits         2705     2705           
  Misses        254      254           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bjlittle
Copy link
Owner Author

Note that reminder annotations are issued in the summary of GHA sessions i.e.,

image

@bjlittle bjlittle merged commit 29bcec7 into main Dec 17, 2024
22 checks passed
@bjlittle bjlittle deleted the pin-gha-base-image branch December 17, 2024 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: gha Auto-labelled
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant