-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a gallery example for regional manifold extraction #1284
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1284 +/- ##
==========================================
+ Coverage 91.34% 91.63% +0.29%
==========================================
Files 58 59 +1
Lines 2959 2990 +31
==========================================
+ Hits 2703 2740 +37
+ Misses 256 250 -6 ☔ View full report in Codecov by Sentry. |
All failing tests should pass once bjlittle/geovista-data#71 is merged in! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ESadek-MO Awesome! Thanks for hanging in there, really appreciated 💯
Just some minor suggestions then we're good to go 🚀
42471d7
to
ded31a1
Compare
@all-contributors please add @ESadek-MO for code and example and data |
I've put up a pull request to add @ESadek-MO! 🎉 |
Closes #1285.
Create a suitable region manifold extraction example:
geovista.examples
category into which to create the examplepooch
registry.txt and associated DATA_VERSIONpytest -m example