Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a gallery example for regional manifold extraction #1284

Merged
merged 11 commits into from
Jan 26, 2025

Conversation

ESadek-MO
Copy link
Collaborator

@ESadek-MO ESadek-MO commented Jan 23, 2025

Closes #1285.

Create a suitable region manifold extraction example:

  • Agree the geovista.examples category into which to create the example
  • Generate and add example test asset to the geovista-data repository
  • Update our pooch registry.txt and associated DATA_VERSION
  • Ensure that the new asset is downloaded, see geovista download
  • Ensure the visual tests pass pytest -m example

@ESadek-MO ESadek-MO requested a review from bjlittle as a code owner January 23, 2025 14:21
@github-actions github-actions bot added the type: examples Auto-labelled for ex/*, example/* and examples/* branches label Jan 23, 2025
@ESadek-MO ESadek-MO marked this pull request as draft January 23, 2025 14:40
@bjlittle bjlittle self-assigned this Jan 23, 2025
@github-actions github-actions bot added the type: cache Auto-labelled label Jan 23, 2025
Copy link

codecov bot commented Jan 23, 2025

Codecov Report

Attention: Patch coverage is 96.87500% with 1 line in your changes missing coverage. Please review.

Project coverage is 91.63%. Comparing base (31334fe) to head (ded31a1).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/geovista/examples/extraction/wedge_manifold.py 96.77% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1284      +/-   ##
==========================================
+ Coverage   91.34%   91.63%   +0.29%     
==========================================
  Files          58       59       +1     
  Lines        2959     2990      +31     
==========================================
+ Hits         2703     2740      +37     
+ Misses        256      250       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ESadek-MO
Copy link
Collaborator Author

All failing tests should pass once bjlittle/geovista-data#71 is merged in!

@ESadek-MO ESadek-MO marked this pull request as ready for review January 23, 2025 17:12
Copy link
Owner

@bjlittle bjlittle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ESadek-MO Awesome! Thanks for hanging in there, really appreciated 💯

Just some minor suggestions then we're good to go 🚀

changelog/1284.documentation.rst Outdated Show resolved Hide resolved
changelog/1284.documentation.rst Outdated Show resolved Hide resolved
src/geovista/examples/extraction/README.rst Outdated Show resolved Hide resolved
src/geovista/examples/extraction/__init__.py Outdated Show resolved Hide resolved
src/geovista/examples/extraction/wedge_manifold.py Outdated Show resolved Hide resolved
src/geovista/examples/extraction/wedge_manifold.py Outdated Show resolved Hide resolved
src/geovista/examples/extraction/wedge_manifold.py Outdated Show resolved Hide resolved
src/geovista/examples/extraction/wedge_manifold.py Outdated Show resolved Hide resolved
src/geovista/examples/extraction/wedge_manifold.py Outdated Show resolved Hide resolved
src/geovista/examples/extraction/wedge_manifold.py Outdated Show resolved Hide resolved
@bjlittle bjlittle enabled auto-merge (squash) January 26, 2025 22:11
@bjlittle bjlittle merged commit b2ce5ab into bjlittle:main Jan 26, 2025
22 checks passed
@bjlittle
Copy link
Owner

@all-contributors please add @ESadek-MO for code and example and data

Copy link
Contributor

@bjlittle

I've put up a pull request to add @ESadek-MO! 🎉

@ESadek-MO ESadek-MO deleted the regional-manifold branch January 27, 2025 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: cache Auto-labelled type: examples Auto-labelled for ex/*, example/* and examples/* branches
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add region manifold extraction example
2 participants