Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add example scripts image test coverage #494

Merged
merged 1 commit into from
Oct 14, 2023
Merged

Conversation

bjlittle
Copy link
Owner

@bjlittle bjlittle commented Oct 12, 2023

🚀 Pull Request

Description

Todo:

  • Check whether using xvfb and software rasterizer MESA on GHA runner affects test image tolerances
  • Relocate image_cache images to geovista-data repo
  • Support pooch download of image_cache assets
  • Extend CLI

@bjlittle bjlittle marked this pull request as draft October 12, 2023 16:27
@github-actions github-actions bot added type: infrastructure Auto-labelled type: testing Auto-labelled type: examples Auto-labelled for ex/*, example/* and examples/* branches labels Oct 12, 2023
@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

Merging #494 (d0e44de) into main (44edaeb) will increase coverage by 4.21%.
The diff coverage is 96.96%.

@@            Coverage Diff             @@
##             main     #494      +/-   ##
==========================================
+ Coverage   90.74%   94.95%   +4.21%     
==========================================
  Files          70      105      +35     
  Lines        3686     4484     +798     
==========================================
+ Hits         3345     4258     +913     
+ Misses        341      226     -115     
Files Coverage Δ
src/geovista/__init__.py 90.90% <100.00%> (+0.90%) ⬆️
src/geovista/cache.py 89.79% <100.00%> (+4.08%) ⬆️
src/geovista/examples/clouds.py 96.15% <ø> (ø)
src/geovista/examples/clouds_robin.py 96.42% <ø> (ø)
src/geovista/examples/earthquakes.py 80.00% <ø> (-0.77%) ⬇️
src/geovista/examples/earthquakes_wink1.py 80.76% <ø> (ø)
src/geovista/examples/from_1d__oisst_eqc.py 95.45% <ø> (ø)
...geovista/examples/from_1d__synthetic_face_m1_n1.py 95.65% <100.00%> (ø)
...ta/examples/from_1d__synthetic_face_m1_n1_robin.py 96.00% <100.00%> (ø)
...geovista/examples/from_1d__synthetic_node_m1_n1.py 95.65% <100.00%> (ø)
... and 23 more

... and 14 files with indirect coverage changes

@bjlittle bjlittle force-pushed the examples-image-tests branch 3 times, most recently from 1eeba77 to f59b268 Compare October 13, 2023 22:24
@bjlittle bjlittle force-pushed the examples-image-tests branch from f59b268 to d0e44de Compare October 13, 2023 22:40
@bjlittle bjlittle marked this pull request as ready for review October 13, 2023 22:46
@bjlittle bjlittle merged commit f78b4c3 into main Oct 14, 2023
19 checks passed
@bjlittle bjlittle deleted the examples-image-tests branch October 14, 2023 08:08
@bjlittle bjlittle self-assigned this Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: examples Auto-labelled for ex/*, example/* and examples/* branches type: infrastructure Auto-labelled type: testing Auto-labelled
Projects
Status: 🏁 Done
Development

Successfully merging this pull request may close these issues.

1 participant