Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adopt pytest xfail-strict #520

Merged
merged 1 commit into from
Nov 20, 2023
Merged

adopt pytest xfail-strict #520

merged 1 commit into from
Nov 20, 2023

Conversation

bjlittle
Copy link
Owner

@bjlittle bjlittle commented Nov 20, 2023

🚀 Pull Request

Description

This pull-request adopts xfail_strict = True for pytest to catch expected failures that succeed i.e., unexpectedly pass rather than fail as expected.


@github-actions github-actions bot added the type: infrastructure Auto-labelled label Nov 20, 2023
Copy link

codecov bot commented Nov 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8977684) 94.97% compared to head (5754712) 94.97%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #520   +/-   ##
=======================================
  Coverage   94.97%   94.97%           
=======================================
  Files         107      107           
  Lines        4620     4620           
=======================================
  Hits         4388     4388           
  Misses        232      232           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bjlittle bjlittle merged commit 7ad30de into main Nov 20, 2023
17 checks passed
@bjlittle bjlittle deleted the adopt-pytest-xfail-strict branch November 20, 2023 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant