Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Bump actions/labeler from 4 to 5" #556

Conversation

tkoyama010
Copy link
Collaborator

Reverts #553

@bjlittle
Copy link
Owner

bjlittle commented Dec 5, 2023

@tkoyama010 Do you understand the breaking change introduced by v5 that is causing the issue?

Copy link

codecov bot commented Dec 5, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b6108fb) 94.88% compared to head (36f3b5b) 94.88%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #556   +/-   ##
=======================================
  Coverage   94.88%   94.88%           
=======================================
  Files         119      119           
  Lines        4730     4730           
=======================================
  Hits         4488     4488           
  Misses        242      242           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bjlittle
Copy link
Owner

bjlittle commented Dec 5, 2023

@tkoyama010 I believe there has been a major syntax change in the API ... I might try to convert to the new format, rather than go back to version v4.

Hang tight and let me investigate 👍

@tkoyama010
Copy link
Collaborator Author

tkoyama010 commented Dec 5, 2023

@bjlittle Yes, I modified the label.yml to the new writing style, but an error occurred. Please let me know if you can resolve this issue. If we can't solve it, let's merge this, and see how other projects solve it for a while.

@tkoyama010 tkoyama010 closed this Dec 6, 2023
@tkoyama010 tkoyama010 deleted the revert-553-dependabot/github_actions/actions/labeler-5 branch December 6, 2023 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants