Skip to content

Commit

Permalink
Improve test names (polkadot-fellows#399)
Browse files Browse the repository at this point in the history
The name of the "All changelog tests passing" was clashing with the name
of the "All tests passing" test.

Give the check features test a name.

Both changes are required to mark these tests as required in github.

<!-- Remember that you can run `/merge` to enable auto-merge in the PR
-->

<!-- Remember to modify the changelog. If you don't need to modify it,
you can check the following box.
Instead, if you have already modified it, simply delete the following
line. -->

- [x] Does not require a CHANGELOG entry
  • Loading branch information
bkchr authored Jul 24, 2024
1 parent 7723274 commit 5fa4ff0
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/changelog.yml
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ jobs:
# If you add more jobs, remember to add them to the "needs" array.
confirmChangelogChecksPassed:
runs-on: ubuntu-latest
name: All tests passed
name: All changelog tests passed
# If any new job gets added, be sure to add it to this list
needs:
- verify-changelog-updated
Expand Down
3 changes: 2 additions & 1 deletion .github/workflows/check-features.yaml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# Various checks to verify the cargo workspace and its crates are correctly configured.
name: "Workspace"
name: "Workspace features"

on:
push:
Expand All @@ -13,6 +13,7 @@ concurrency:
cancel-in-progress: true

jobs:
name: Check workspace features
check:
runs-on: ubuntu-22.04

Expand Down

0 comments on commit 5fa4ff0

Please sign in to comment.