Skip to content

Commit

Permalink
Don't warn for empty ([]) rules
Browse files Browse the repository at this point in the history
this has been fixed a long time ago.
  • Loading branch information
black-sliver committed May 9, 2024
1 parent e5cdcf1 commit ac8c490
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions src/core/location.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,7 @@ std::list<Location> Location::FromJSON(json& j, const std::list<Location>& paren
}
} else {
accessRules = parentAccessRules; // TODO: avoid copy
if (!j["access_rules"].is_null()) {
if (!j["access_rules"].is_null() && !j["access_rules"].is_array()) {
fprintf(stderr, "Location: invalid access rules in \"%s\"\n",
sanitize_print(name).c_str());
}
Expand Down Expand Up @@ -225,7 +225,7 @@ std::list<Location> Location::FromJSON(json& j, const std::list<Location>& paren
}
} else {
visibilityRules = parentVisibilityRules; // TODO: avoid copy
if (!j["visibility_rules"].is_null()) {
if (!j["visibility_rules"].is_null() && !j["visibility_rules"].is_array()) {
fprintf(stderr, "Location: invalid visibility rules in \"%s\"\n",
sanitize_print(name).c_str());
}
Expand Down Expand Up @@ -382,7 +382,7 @@ LocationSection LocationSection::FromJSON(json& j, const std::string parentId, c
}
} else {
sec._accessRules = parentAccessRules;
if (!j["access_rules"].is_null()) {
if (!j["access_rules"].is_null() && !j["access_rules"].is_array()) {
fprintf(stderr, "Location: Section: invalid access rules in \"%s\"\n",
sanitize_print(sec._name).c_str());
}
Expand Down Expand Up @@ -416,7 +416,7 @@ LocationSection LocationSection::FromJSON(json& j, const std::string parentId, c
}
} else {
sec._visibilityRules = parentVisibilityRules;
if (!j["visibility_rules"].is_null()) {
if (!j["visibility_rules"].is_null() && !j["visibility_rules"].is_array()) {
fprintf(stderr, "Location: Section: invalid visibility rules in \"%s\"\n",
sanitize_print(sec._name).c_str());
}
Expand Down

0 comments on commit ac8c490

Please sign in to comment.