Make logic resolving 4x faster and allow CI codes for stages #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not all code comparisons were case-insensitive (CI). Also adds tests, primarily for CI. Introduces an object cache that could change behaviour in some packs but shouldn't. Replaces list<> by vector<> for code. Testing if vector<> for _ciAllCodes would be better was not done yet (TODO).
black-sliver
force-pushed
the
improve-performance
branch
2 times, most recently
from
2d9056b to
958df39
Compare
black-sliver
force-pushed
the
improve-performance
branch
2 times, most recently
from
fc58bf1 to
a541449
Compare
black-sliver
force-pushed
the
improve-performance
branch
from
a541449 to
627245b
Compare
This is opt-in because it could change behaviour, so please test and set Tracker.AllowDeferredLogicUpdate to true or false.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not all code comparisons were case-insensitive (CI). Also adds tests, primarily for CI.
Introduces an object cache that could change behaviour in some packs but shouldn't.
Replaces list<> by vector<> for code and adds an extra set that contains all lower case codes for faster checking.
Testing if vector<> for _ciAllCodes would be better was not done yet (TODO).
Allows to opt into deferred logic updates via
to run fewer logic updates (currently only uses when switching from bulk update back to normal update).