Added implementation of client_ed25519 authentification method #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have tried my best at implementing a fix for issue #138 by following the given reference implementation as well as the RFC at https://www.rfc-editor.org/rfc/rfc8032#section-5.1.5.
I have aligned my code as best as I can to the references given above and I have tested this locally using a modified
mysql_async. However I am no expert on cryptography and cannot in good conscience take responsibility for the cryptographic correctness, as I am relying on low-level elliptic curve computations.If anyone could provide feedback and test data, I would very much appreciate it.
If this is accepted, I have already prepared the necessary changes to https://github.com/blackbeam/mysql_async/ as well. Should I open a separate pull request already, or wait?
Best regards!