Added localization support to name/description elements #108
Conversation
|
|
||
| for (var prop in widgetConfig.name) { |
There was a problem hiding this comment.
This is not actually an Array, so forEach is not available.
|
@tracyli - can you test this soon as this needs to be in for tomorrows build? |
|
tested in mac with package build http://ci0000003863287:8080/hudson/job/BB10-Webworks-Packager-twg_next-name-localization/4/: |
|
@tracyli Can you please test @EricLeiLi change as part of this pull request. Shouldn't need to retest my stuff. |
|
@tracyli checkout blackberry#210 for details of packageLocale. You can contact me directly if you prefer. |
|
@tracyli I fixed the unit test. Let's wait for the next CI. |
| } | ||
| } | ||
|
|
||
| if (tagData instanceof Array) { |
|
This requires a microsite issue |
| for (locale in localeElements) { | ||
| if (localeElements.hasOwnProperty(locale)) { | ||
| //Don't add default locale and don't add locale if it already exists | ||
| if (locale !== 'default' && locales.indexOf(locale) === -1) { |
+Hijacked data2mxl node module in order to fix a bug in their code. Thanks to @sleroux for a large portion of this work. Fixes blackberry#122
|
Removed @EricLeiLi commit. @jeffheifetz Can you r+ this before we get @tracyli to retest. |
|
Jake lint fails for me |
|
tested in winxp and mac with http://ci0000003863287:8080/hudson/job/BB10-Webworks-Packager-twg_next-name-localization/12/: smoke test got passed;'name' can change when localization language changes; |
|
r+ |
+Hijacked data2mxl node module in order to fix a bug in their code.
Thanks to @sleroux for a large portion of this work.
Fixes blackberry#122