-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added code to parse category in config.xml #93
base: next
Are you sure you want to change the base?
Conversation
…into generated tabletXML and later in manifest during packaging.
…ong attribute specified
What does this category flag represent? When will it be used? Not sure what this change is related to... Thanks! |
@kwallis The rim:category element specifies the category for the location of your BlackBerry WebWorks application. For example, if your application is a game, you can specify that your application is installed in the Games folder on the BlackBerry tablet. https://developer.blackberry.com/html5/documentation/rim_category_element_1685032_11.html |
Thanks Misha. This categorization on the device was dropped on the PlayBook as of version 2.0 I think. It also does not exist at all on BlackBerry 10 devices, so unfortunately I don't think this change is required. Thanks! This transmission (including any attachments) may contain confidential information, privileged material (including material protected by the solicitor-client or other applicable privileges), or constitute non-public information. Any use of this information by anyone other than the intended recipient is prohibited. If you have received this transmission in error, please immediately reply to the sender and delete this information from your system. Use, dissemination, distribution, or reproduction of this transmission by unintended recipients is not authorized and may be unlawful. |
@kwallis it is required for QNX auto because they have categories I assume. right @lytvynyuk ? we just need to confirm that it doesn't have any negative BB10 impact and then we can let it in. @kwallis any issues with this approach? |
Or perhaps the solution is to port your pre-processor work to the packager as well @nukulb |
Can we explore that? I am hesitant to set precedent of adding stuff generally into config.xml parsing/packager etc. for one specific client if it can be avoided... Ken Wallis Product Manager – BlackBerry WebWorks Research In Motion (905) 629-4746 x14369 From: Jeffrey Heifetz [[email protected]] Or perhaps the solution is to port your pre-processor work to the packager as well @nukulbhttps://github.com/nukulb — This transmission (including any attachments) may contain confidential information, privileged material (including material protected by the solicitor-client or other applicable privileges), or constitute non-public information. Any use of this information by anyone other than the intended recipient is prohibited. If you have received this transmission in error, please immediately reply to the sender and delete this information from your system. Use, dissemination, distribution, or reproduction of this transmission by unintended recipients is not authorized and may be unlawful. |
Its no big deal I think to include it, I don't want also preprocess the packager if we don't need to but its an option. From: Ken Wallis <[email protected]mailto:[email protected]> Can we explore that? I am hesitant to set precedent of adding stuff generally into config.xml parsing/packager etc. for one specific client if it can be avoided... Ken Wallis Product Manager – BlackBerry WebWorks Research In Motion (905) 629-4746 x14369 From: Jeffrey Heifetz [[email protected]:[email protected]] Or perhaps the solution is to port your pre-processor work to the packager as well @nukulbhttps://github.com/nukulb — This transmission (including any attachments) may contain confidential information, privileged material (including material protected by the solicitor-client or other applicable privileges), or constitute non-public information. Any use of this information by anyone other than the intended recipient is prohibited. If you have received this transmission in error, please immediately reply to the sender and delete this information from your system. Use, dissemination, distribution, or reproduction of this transmission by unintended recipients is not authorized and may be unlawful. — This transmission (including any attachments) may contain confidential information, privileged material (including material protected by the solicitor-client or other applicable privileges), or constitute non-public information. Any use of this information by anyone other than the intended recipient is prohibited. If you have received this transmission in error, please immediately reply to the sender and delete this information from your system. Use, dissemination, distribution, or reproduction of this transmission by unintended recipients is not authorized and may be unlawful. |
Category support in native-packager will be kept for backwards compatibility. |
I would like to know what is the status of this pull request. Is there anything else I can do to proceed ? |
Added code to parse category in config.xml and to add parsed category to generated tabletXML; this category will end-up in manifest during packaging.
Added Unit test