Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added code to parse category in config.xml #93

Open
wants to merge 3 commits into
base: next
Choose a base branch
from

Conversation

lytvynyuk
Copy link

Added code to parse category in config.xml and to add parsed category to generated tabletXML; this category will end-up in manifest during packaging.

Added Unit test

@kwallis
Copy link

kwallis commented Oct 10, 2012

What does this category flag represent? When will it be used? Not sure what this change is related to...

Thanks!

@lytvynyuk
Copy link
Author

@kwallis
This is about settings a category for the application:

The rim:category element specifies the category for the location of your BlackBerry WebWorks application. For example, if your application is a game, you can specify that your application is installed in the Games folder on the BlackBerry tablet.

https://developer.blackberry.com/html5/documentation/rim_category_element_1685032_11.html

@kwallis
Copy link

kwallis commented Oct 10, 2012

Thanks Misha. This categorization on the device was dropped on the PlayBook as of version 2.0 I think. It also does not exist at all on BlackBerry 10 devices, so unfortunately I don't think this change is required.

Thanks!


This transmission (including any attachments) may contain confidential information, privileged material (including material protected by the solicitor-client or other applicable privileges), or constitute non-public information. Any use of this information by anyone other than the intended recipient is prohibited. If you have received this transmission in error, please immediately reply to the sender and delete this information from your system. Use, dissemination, distribution, or reproduction of this transmission by unintended recipients is not authorized and may be unlawful.

@nukulb
Copy link

nukulb commented Oct 11, 2012

@kwallis it is required for QNX auto because they have categories I assume. right @lytvynyuk ?

we just need to confirm that it doesn't have any negative BB10 impact and then we can let it in. @kwallis any issues with this approach?

@lytvynyuk
Copy link
Author

@kwallis , @nukulb yes, we need this for QNX CAR. Also I would like to confirm with platform people if they planing to keep this feature in native packager, currently it works, but I have no idea what are the future plans.

@jeffheifetz
Copy link

Or perhaps the solution is to port your pre-processor work to the packager as well @nukulb

@kwallis
Copy link

kwallis commented Oct 11, 2012

Can we explore that? I am hesitant to set precedent of adding stuff generally into config.xml parsing/packager etc. for one specific client if it can be avoided...

Ken Wallis

Product Manager – BlackBerry WebWorks

Research In Motion

(905) 629-4746 x14369


From: Jeffrey Heifetz [[email protected]]
Sent: Thursday, October 11, 2012 11:55 AM
To: blackberry-webworks/BB10-Webworks-Packager
Cc: Ken Wallis
Subject: Re: [BB10-Webworks-Packager] Added code to parse category in config.xml (#93)

Or perhaps the solution is to port your pre-processor work to the packager as well @nukulbhttps://github.com/nukulb


Reply to this email directly or view it on GitHubhttps://github.com//pull/93#issuecomment-9345876.


This transmission (including any attachments) may contain confidential information, privileged material (including material protected by the solicitor-client or other applicable privileges), or constitute non-public information. Any use of this information by anyone other than the intended recipient is prohibited. If you have received this transmission in error, please immediately reply to the sender and delete this information from your system. Use, dissemination, distribution, or reproduction of this transmission by unintended recipients is not authorized and may be unlawful.

@nukulb
Copy link

nukulb commented Oct 11, 2012

Its no big deal I think to include it, I don't want also preprocess the packager if we don't need to but its an option.

From: Ken Wallis <[email protected]mailto:[email protected]>
Reply-To: blackberry-webworks/BB10-Webworks-Packager <[email protected]mailto:[email protected]>
Date: Thu, 11 Oct 2012 09:10:11 -0700
To: blackberry-webworks/BB10-Webworks-Packager <[email protected]mailto:[email protected]>
Cc: Nukul Bhasin <[email protected]mailto:[email protected]>
Subject: Re: [BB10-Webworks-Packager] Added code to parse category in config.xml (#93)

Can we explore that? I am hesitant to set precedent of adding stuff generally into config.xml parsing/packager etc. for one specific client if it can be avoided...

Ken Wallis

Product Manager – BlackBerry WebWorks

Research In Motion

(905) 629-4746 x14369


From: Jeffrey Heifetz [[email protected]:[email protected]]
Sent: Thursday, October 11, 2012 11:55 AM
To: blackberry-webworks/BB10-Webworks-Packager
Cc: Ken Wallis
Subject: Re: [BB10-Webworks-Packager] Added code to parse category in config.xml (#93)

Or perhaps the solution is to port your pre-processor work to the packager as well @nukulbhttps://github.com/nukulb


Reply to this email directly or view it on GitHubhttps://github.com//pull/93#issuecomment-9345876.


This transmission (including any attachments) may contain confidential information, privileged material (including material protected by the solicitor-client or other applicable privileges), or constitute non-public information. Any use of this information by anyone other than the intended recipient is prohibited. If you have received this transmission in error, please immediately reply to the sender and delete this information from your system. Use, dissemination, distribution, or reproduction of this transmission by unintended recipients is not authorized and may be unlawful.


Reply to this email directly or view it on GitHubhttps://github.com//pull/93#issuecomment-9346440.


This transmission (including any attachments) may contain confidential information, privileged material (including material protected by the solicitor-client or other applicable privileges), or constitute non-public information. Any use of this information by anyone other than the intended recipient is prohibited. If you have received this transmission in error, please immediately reply to the sender and delete this information from your system. Use, dissemination, distribution, or reproduction of this transmission by unintended recipients is not authorized and may be unlawful.

@lytvynyuk
Copy link
Author

Category support in native-packager will be kept for backwards compatibility.

@lytvynyuk
Copy link
Author

I would like to know what is the status of this pull request. Is there anything else I can do to proceed ?

@jeffheifetz
Copy link

This pull request needs to be re-targetted to the blackberry repo. But ultimately @kwallis and @nukulb need to decide if this is something we want to implement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants