Skip to content
This repository has been archived by the owner on Sep 4, 2019. It is now read-only.

Updates the test-suite command for better reporting to the console. Also #478

Open
wants to merge 3 commits into
base: next
Choose a base branch
from

Conversation

jeffheifetz
Copy link
Contributor

adds two more apps to the suite.

Reviewed By: Nukul Bhasin <[email protected]>
Tested By: Hassan Ahmad <[email protected]>

</script>
</head>
<body>
</body>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this just indentation chnage?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it also includes updates to the data sent back and forth. You were only sending useful data on spec results, I send data on spec, suite and runner results. Additionally I send when the runner starts.

@nukulb
Copy link
Contributor

nukulb commented Dec 13, 2012

There is some stuff I really like and some I don't :)

so the idea behind the structure before was that you could write special types of deploy tests.
For example invoke could deploy three apps at the same time and test the output from each.

This process queue is not robust enough to handle this because its all in one big test-suite

You should not make jake test-suite into this because you will need to run all of them all the time

We are losing the ability to write better tests this way by hiding the cli and deploy.

If I want to write invoke tests now I need to write a new process queue with a new jake task.

The most awesome advantage of the previous structure was that I could run

jake test-suite test/test-suite/test/whitelist-test-runner.js

to only run whitelist tests.

Now that everything is into jake test-suite I cant do that anymore

The reporter is a great addition but I don't think we should be giving up the advantages I mentioned above

Perhaps you should leave jake test-suite the way it was and simply add the reporter to it

then bring back whitelist-test-runner and posisbly create a default runner people can inherit from.

Does that make sense? I could be missing something as well

@nukulb
Copy link
Contributor

nukulb commented Dec 14, 2012

So are we doing anything with this?

@jeffheifetz
Copy link
Contributor Author

I have an idea I'm playing around with

@jeffheifetz
Copy link
Contributor Author

@nukulb OK, I rewrote this based on our discussions, tell me what you think now.

@jeffheifetz
Copy link
Contributor Author

@nukulb ping

@jeffheifetz
Copy link
Contributor Author

@nukulb ping again

@nukulb
Copy link
Contributor

nukulb commented Feb 12, 2013

r+

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants