This repository has been archived by the owner on Sep 4, 2019. It is now read-only.
Fixed the missing fs.copySync patch in native-packager.js #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jkeshavarzi review please |
|
r+ |
|
lint error lib/native-packager.js: line 64, col 9, 'packagerUtils' is not defined. 1 error lib/native-packager.js : |
Fixes blackberry#239 Reviewed By: @jkeshavarzi Tested By: @EricLeiLi
|
Fixed lint, now testing. |
|
Jake test and lint passed; |
|
merged |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fs.copySync is deprecated in node 0.8.14 and we all changed it to packagerUtils.copyFile. However, the location (for appdesc use case) is missing in native-packager.js, we need to fix it.
Fixes #239
Reviewed By: @jkeshavarzi
Tested By: @tracyli