This repository has been archived by the owner on Sep 4, 2019. It is now read-only.
Update permit for HTML5 geolocation #407
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not true for playbook |
|
Good point! I amended the commit. Let me know if it is ok - I didn't see other examples of multiple permit attributes. |
|
Thats because we have never had this come up before. Currently there is a way to specify that a featureId is valid for only a given set of OSes (using the type {} option). Would we like to add this ability for permissions? |
|
I suggest we merge this into master ASAP. It seems to be causing confusion in the community. |
|
Issue tracked in #419, r+ |
|
Woops, needs to be retargetted to master |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #406