OTWO-6954 api for create scan project #1716
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Niharika1117
force-pushed
the
OTWO-6954
branch
2 times, most recently
from
2c9ba2e to
9ed14f9
Compare
| @@ -63,4 +71,14 @@ def code_location_branch(url) | |||
| out, _err, _status = Open3.capture3("git ls-remote --symref #{url} HEAD | head -1 | awk '{print $2}'") | |||
| out.strip.sub(/refs\/heads\//, '') | |||
| end | |||
|
|
|||
| def get_scan_api_data(url, path) | |||
| project = populate_project_from_forge(url, true) | |||
There was a problem hiding this comment.
I'm a bit confused by this line. Why do we have to go to the forge? The project already exists on Openhub. Don't we need to pass in the codelocation.repository.url to the scan api?
We could pass in the project id into the api.
Niharika1117
force-pushed
the
OTWO-6954
branch
2 times, most recently
from
39d509c to
b515410
Compare
notalex
approved these changes
Mar 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.