[feature] heartbeat, [niconico] fix: download video #86
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting a pull request make sure you have:
In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:
This is based on unmerged patches by
@Gorfiend unqueued/youtube-dl-prs@8499534
@nekojun unqueued/youtube-dl-prs@5a6f5f9
I used a thread that sleeps rather than creating a timer thread on each heartbeat. Btw, @unqueued did great work making that pull request repo.
What is the purpose of your pull request?
Fixes #72
This adds a Heartbeat feature that makes requests at some interval, while downloading. Some video sites require this, or they cancel the download.