Skip to content

Commit

Permalink
Fix preservation of scan id at scan init
Browse files Browse the repository at this point in the history
I noticed this change here: 02acd94#diff-c6756c35a5fb1d7b87dc0ed3d33a2d211374dc196f245d26a362c82c8c346d5cR131

I can only assume it was unintentional, given `id` is a python builtin function, and `str(id)` returns:
```py
cmyui@Joshs-MacBook-Pro ~ % python3
Python 3.13.0 (main, Oct  7 2024, 05:02:14) [Clang 15.0.0 (clang-1500.3.9.4)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> str(id)
'<built-in function id>'
```
  • Loading branch information
cmyui authored Nov 18, 2024
1 parent 49f094b commit 7030aa2
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion bbot/scanner/scanner.py
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ def __init__(
self._success = False

if scan_id is not None:
self.id = str(id)
self.id = str(scan_id)
else:
self.id = f"SCAN:{sha1(rand_string(20)).hexdigest()}"

Expand Down

0 comments on commit 7030aa2

Please sign in to comment.