Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Asset inventory bugfixes and improvements #1010

Merged
merged 6 commits into from
Jan 19, 2024

Conversation

TheTechromancer
Copy link
Collaborator

No description provided.

Copy link

codecov bot commented Jan 18, 2024

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (61e556a) 92% compared to head (d9a8074) 92%.

Files Patch % Lines
bbot/modules/output/asset_inventory.py 76% 6 Missing ⚠️
bbot/core/event/base.py 90% 2 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##             dev   #1010   +/-   ##
=====================================
- Coverage     92%     92%   -0%     
=====================================
  Files        305     305           
  Lines      19171   19194   +23     
=====================================
+ Hits       17627   17639   +12     
- Misses      1544    1555   +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TheTechromancer
Copy link
Collaborator Author

image

Fixed this bug, added internal IP column as suggested by @amiremami

@TheTechromancer TheTechromancer merged commit 70328ce into dev Jan 19, 2024
@TheTechromancer TheTechromancer deleted the improved-asset-inventory branch January 22, 2024 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants