Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSON module: option for SIEM-friendly output #1049

Merged
merged 3 commits into from
Feb 2, 2024
Merged

Conversation

TheTechromancer
Copy link
Collaborator

@TheTechromancer TheTechromancer commented Feb 1, 2024

Addresses the SIEM friendliness of BBOT data as discussed in #755.

@nicpenning

This PR adds an option to the json output module, siem_friendly, which when set to true, will format the JSON differently:

{
  "type": "DNS_NAME",
  "data": {
    "DNS_NAME": "blacklanternsecurity.com"
  }
}

Copy link

codecov bot commented Feb 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a824a5e) 92% compared to head (bdac5d6) 92%.
Report is 1 commits behind head on dev.

Additional details and impacted files
@@          Coverage Diff          @@
##             dev   #1049   +/-   ##
=====================================
- Coverage     92%     92%   -0%     
=====================================
  Files        304     304           
  Lines      19269   19283   +14     
=====================================
- Hits       17724   17711   -13     
- Misses      1545    1572   +27     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TheTechromancer TheTechromancer merged commit 11f5eeb into dev Feb 2, 2024
8 checks passed
@nicpenning
Copy link
Contributor

Woohoo! Will test soon, thank you! 🙏

@nicpenning
Copy link
Contributor

FYI - Elastic Integration being built to take advantage of this work.

elastic/integrations#9427

@CarsonHrusovsky
Copy link

This is very exciting!

@TheTechromancer TheTechromancer deleted the siem-friendly-json branch May 16, 2024 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants