Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Newsletters Module #1072

Merged
merged 20 commits into from
Feb 9, 2024
Merged

Newsletters Module #1072

merged 20 commits into from
Feb 9, 2024

Conversation

stryker2k2
Copy link
Collaborator

@stryker2k2 stryker2k2 commented Feb 6, 2024

Description:

  • Created a new module called 'newsletters' that will scrap the websites (or recursive websites, thanks to BBOT's sub-domain enumeration) looking for the presence of an 'email type' that also contains a 'placeholder'. The combination of these two HTML items usually signify the presence of an "Enter Your Email Here" type Newsletter Subscription service. This module could be used to find newsletters for a future email bombing attack and/or find user-input fields that could be be susceptible to overflows or injections.

Ticket/Issue

To Review:

  • Run BBOT Module on a website without a Newsletter (ex: blacklanternsecurity.com)
    • bbot -m httpx newsletters -t blacklanternsecurity.com
    • Expect 0 Newsletter Events
  • Run BBOT Module on a website WITH a Newsletter (ex: futureparty.com)
    • bbot -m httpx newsletters -t futureparty.com
    • Expect 1 or more Newsletter Events
  • View output on neo4j to ensure it displays well
  • Code Review
  • Tests Review

Notes:

  • Must be ran with with 'httpx'
  • bbot -m httpx newsletters -t <insert target here>

@stryker2k2
Copy link
Collaborator Author

I will be resolving the merge conflicts (via command line) as well as modifying the test_module_newsletters. I'd like to make two checks, one for WITH newsletters and one for WITHOUT newsletters. I currently have one check that fails if either one doesn't pass.

Copy link

codecov bot commented Feb 8, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (159ef6e) 92% compared to head (0e34a80) 92%.

Files Patch % Lines
...est_step_2/module_tests/test_module_newsletters.py 93% 2 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##             dev   #1072   +/-   ##
=====================================
+ Coverage     92%     92%   +1%     
=====================================
  Files        304     306    +2     
  Lines      19306   19357   +51     
=====================================
+ Hits       17760   17807   +47     
- Misses      1546    1550    +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

class newsletters(BaseModule):
watched_events = ["HTTP_RESPONSE"]
produced_events = ["FINDING"]
flags = ["passive", "safe"]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"passive" here should be "active" since it relies on web requests.

lint-tests.sh Outdated Show resolved Hide resolved
@TheTechromancer TheTechromancer merged commit cb182de into dev Feb 9, 2024
8 checks passed
@stryker2k2
Copy link
Collaborator Author

Yippie!

@stryker2k2 stryker2k2 mentioned this pull request Feb 9, 2024
6 tasks
@TheTechromancer TheTechromancer deleted the newsletters branch March 7, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants