Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Module: gitlab #1169

Merged
merged 18 commits into from
Mar 25, 2024
Merged

New Module: gitlab #1169

merged 18 commits into from
Mar 25, 2024

Conversation

TheTechromancer
Copy link
Collaborator

@TheTechromancer TheTechromancer commented Mar 11, 2024

New GitLab module:

  • Detects GitLab from HTTP_RESPONSE (--> TECHNOLOGY)
  • Consumes its own TECHNOLOGY events and enumerates users and groups on the gitlab server (--> SOCIAL)
  • Consumes its own SOCIAL events and enumerates code repos (--> CODE_REPOSITORY)

Test command:

bbot -m httpx gitlab -t gitlab.eecs.wsu.edu

TODO:

  • Tests
    • self-hosted
    • gitlab.org
  • Authentication support

Designed to work with @domwhewell-sage's git_clone.

Included as part of this PR is a small addition to speculate that derives URL_UNVERIFIED events from other events that include a URL. This is relevant to gitlab because it guarantees that when a CODE_REPOSITORY or SOCIAL is raised, it will have a matching URL_UNVERIFIED. This is what prompted the minor tweaks to the various other tests.

@TheTechromancer TheTechromancer self-assigned this Mar 11, 2024
@TheTechromancer TheTechromancer changed the title New Module: Gitlab New Module: gitlab Mar 11, 2024
@TheTechromancer TheTechromancer marked this pull request as ready for review March 19, 2024 05:04
@codecov-commenter
Copy link

codecov-commenter commented Mar 24, 2024

Codecov Report

Attention: Patch coverage is 95.89041% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 92%. Comparing base (34859f9) to head (c1611d1).

Files Patch % Lines
bbot/modules/gitlab.py 91% 9 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##             dev   #1169    +/-   ##
======================================
+ Coverage     92%     92%    +1%     
======================================
  Files        314     316     +2     
  Lines      19939   20091   +152     
======================================
+ Hits       18318   18463   +145     
- Misses      1621    1628     +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TheTechromancer TheTechromancer merged commit a317845 into dev Mar 25, 2024
8 checks passed
@TheTechromancer TheTechromancer deleted the gitlab branch May 16, 2024 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants