-
Notifications
You must be signed in to change notification settings - Fork 568
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shared Ansible Dependencies #1270
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## module-hooks #1270 +/- ##
=============================================
- Coverage 92% 91% -0%
=============================================
Files 323 325 +2
Lines 21493 21611 +118
=============================================
+ Hits 19562 19660 +98
- Misses 1931 1951 +20 ☔ View full report in Codecov by Sentry. |
Implement Radix Tree
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Author walked me through this Pull Request. All questions were answered. Code looks good. Test look legit.
Faster Regexes
This PR adds shared ansible dependencies, a feature that carves out a dedicated place for common third-party ansible dependencies such as
ffuf
,massdns
,chromium
, etc:This is designed to prevent multiple modules from having to define the same ansible dependency.
Modules can leverage these dependencies by including them in their
deps_common
attribute: