Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shared Ansible Dependencies #1270

Merged
merged 33 commits into from
Apr 26, 2024
Merged

Shared Ansible Dependencies #1270

merged 33 commits into from
Apr 26, 2024

Conversation

TheTechromancer
Copy link
Collaborator

@TheTechromancer TheTechromancer commented Apr 16, 2024

This PR adds shared ansible dependencies, a feature that carves out a dedicated place for common third-party ansible dependencies such as ffuf, massdns, chromium, etc:

image

This is designed to prevent multiple modules from having to define the same ansible dependency.

Modules can leverage these dependencies by including them in their deps_common attribute:
image

@TheTechromancer TheTechromancer self-assigned this Apr 16, 2024
@TheTechromancer TheTechromancer changed the title Shared Module Dependencies Shared Ansible Dependencies Apr 16, 2024
This was referenced Apr 16, 2024
@codecov-commenter
Copy link

codecov-commenter commented Apr 17, 2024

Codecov Report

Attention: Patch coverage is 95.68106% with 13 lines in your changes are missing coverage. Please review.

Project coverage is 91%. Comparing base (1a45c9c) to head (fad1afe).

Files Patch % Lines
bbot/core/helpers/regex.py 91% 4 Missing ⚠️
bbot/core/modules.py 89% 3 Missing ⚠️
bbot/core/helpers/dns/engine.py 84% 2 Missing ⚠️
bbot/core/helpers/misc.py 67% 2 Missing ⚠️
bbot/core/helpers/helper.py 96% 1 Missing ⚠️
bbot/modules/wafw00f.py 67% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##           module-hooks   #1270    +/-   ##
=============================================
- Coverage            92%     91%    -0%     
=============================================
  Files               323     325     +2     
  Lines             21493   21611   +118     
=============================================
+ Hits              19562   19660    +98     
- Misses             1931    1951    +20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@stryker2k2 stryker2k2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Author walked me through this Pull Request. All questions were answered. Code looks good. Test look legit.

@TheTechromancer TheTechromancer merged commit 92e2fd3 into module-hooks Apr 26, 2024
5 checks passed
@TheTechromancer TheTechromancer deleted the shared-module-deps branch May 16, 2024 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants