Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Faster Regexes #1278

Merged
merged 21 commits into from
Apr 26, 2024
Merged

Faster Regexes #1278

merged 21 commits into from
Apr 26, 2024

Conversation

TheTechromancer
Copy link
Collaborator

Addresses #1184. Uses the regex library as a drop-in replacement for re. regex releases the GIL during its operation, so by pairing it with run_in_executor(), we can effectively offload regex process into other CPU cores.

TODO:

  • Documentation for new regex helpers

@TheTechromancer TheTechromancer self-assigned this Apr 17, 2024
This was referenced Apr 17, 2024
@codecov-commenter
Copy link

codecov-commenter commented Apr 17, 2024

Codecov Report

Attention: Patch coverage is 95.20000% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 91%. Comparing base (ecad649) to head (7baf219).

❗ Current head 7baf219 differs from pull request most recent head 6feb345. Consider uploading reports for the commit 6feb345 to get more accurate results

Files Patch % Lines
bbot/core/helpers/regex.py 91% 4 Missing ⚠️
bbot/core/helpers/helper.py 96% 1 Missing ⚠️
bbot/modules/wafw00f.py 67% 1 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                 @@
##           shared-module-deps   #1278   +/-   ##
==================================================
- Coverage                  92%     91%   -0%     
==================================================
  Files                     324     325    +1     
  Lines                   21531   21582   +51     
==================================================
+ Hits                    19594   19628   +34     
- Misses                   1937    1954   +17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TheTechromancer TheTechromancer merged commit fad1afe into shared-module-deps Apr 26, 2024
5 checks passed
@TheTechromancer TheTechromancer deleted the faster-regexes branch May 16, 2024 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants