Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helperify Massdns #1303

Merged
merged 28 commits into from
May 8, 2024
Merged

Helperify Massdns #1303

merged 28 commits into from
May 8, 2024

Conversation

TheTechromancer
Copy link
Collaborator

@TheTechromancer TheTechromancer commented Apr 24, 2024

This PR promotes massdns to a scan-level helper that can be accessed like this:

self.helpers.dns.brute(module, domain, subdomains)

This PR also contains various code organization improvements:

  • dnscommonsrv has been updated to use the new brute helper
  • the (very huge and complex) massdns module has been split into two smaller, simpler ones: dnsbrute and dnsbrute_mutations
  • new bloom filter implementation to allow for larger brute-force runs with lower memory requirements (dnsbrute_mutations memory usage is now capped at 100MB)

TODO:

  • Update module names, config options in documentation

@TheTechromancer TheTechromancer self-assigned this Apr 24, 2024
@TheTechromancer TheTechromancer mentioned this pull request Apr 24, 2024
42 tasks
@codecov-commenter
Copy link

codecov-commenter commented Apr 24, 2024

Codecov Report

Attention: Patch coverage is 93.00971% with 36 lines in your changes are missing coverage. Please review.

Project coverage is 92%. Comparing base (1720e42) to head (b202086).
Report is 3 commits behind head on bbot-2.0.

Files Patch % Lines
bbot/modules/dnsbrute_mutations.py 88% 12 Missing ⚠️
bbot/core/helpers/dns/brute.py 89% 11 Missing ⚠️
bbot/modules/base.py 0% 4 Missing ⚠️
bbot/core/helpers/bloom.py 96% 2 Missing ⚠️
...t/test_step_2/module_tests/test_module_dnsbrute.py 97% 2 Missing ⚠️
...p_2/module_tests/test_module_dnsbrute_mutations.py 92% 2 Missing ⚠️
...st_step_2/module_tests/test_module_dnscommonsrv.py 85% 2 Missing ⚠️
bbot/modules/templates/subdomain_enum.py 92% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##           bbot-2.0   #1303    +/-   ##
=========================================
+ Coverage        92%     92%    +1%     
=========================================
  Files           328     333     +5     
  Lines         22067   22224   +157     
=========================================
+ Hits          20124   20314   +190     
+ Misses         1943    1910    -33     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TheTechromancer TheTechromancer mentioned this pull request Apr 25, 2024
@TheTechromancer TheTechromancer changed the base branch from faster-regexes to bbot-2.0 May 1, 2024 16:39
@TheTechromancer TheTechromancer merged commit 5cef4c0 into bbot-2.0 May 8, 2024
8 checks passed
@TheTechromancer TheTechromancer deleted the dnsbrute-helperify branch May 16, 2024 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants