Enhancement: Trufflehog #1343
Merged
Enhancement: Trufflehog #1343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enhances the trufflehog module.
I have removed the
filter_eventso trufflehog now accepts allFILESYSTEMevents, if they are not tagged withdockerorgitit will use truffle hogs filesystem command against it.FILESYSTEMevents can have a description field which allows the prior event to inject some extra context into the what exactly the file is that's been downloaded and where it came from.git doesn't need this as the repository URL is included in the trufflehog event (I presume it gets this from the .git file). But I have added it to the
docker_pullevent that's emitted to give the user some extra context instead of "imagename_latest.tar had this plain-text credential"I decided against de-duplicating the findings output by trufflehog inside this module as we may loose some valuable data from other assets that are not workflow-logs. De-duplication of that should be done in that module.
Finally I have upped the version number of trufflehog to the latest.