-
Notifications
You must be signed in to change notification settings - Fork 560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests for multiple OS families #1476
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #1476 +/- ##
=====================================
+ Coverage 93% 93% +1%
=====================================
Files 354 354
Lines 27456 27458 +2
=====================================
+ Hits 25315 25329 +14
+ Misses 2141 2129 -12 ☔ View full report in Codecov by Sentry. |
@domwhewell-sage we've run into a potential issue with these tests. In order to test BBOT on multiple OS families, we need to run the tests inside a docker container. This will cause the dastardly tests to fail, since we can't do docker-in-docker. 🤔🤔 |
Do you think it would be possible to add this to the dastardly test @pytest.mark.skipif(not subprocess.run(['docker', '--version'], capture_output=True).returncode == 0,
reason="Docker is not installed") |
Hmm I guess we could exclude it from the os family tests, but modules like dastardly with big dependencies are the reason we need those tests to begin with. I'll see about excluding it for now, and maybe we can figure out a better solution further down the road. |
94ff80a
to
d8a32ae
Compare
905b332
to
3c6728c
Compare
Addresses #1469.
Tests these Linux distros:
Uses pyenv to install the latest python3.11.