Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update and Optimize Neo4j #1582

Merged
merged 16 commits into from
Jul 30, 2024
Merged

Update and Optimize Neo4j #1582

merged 16 commits into from
Jul 30, 2024

Conversation

TheTechromancer
Copy link
Collaborator

@TheTechromancer TheTechromancer commented Jul 24, 2024

This PR updates Neo4j by removing the deprecated use of id() (#1531) and also converts the module into batch mode for better efficiency (#1452).

Also included in this PR are a few small tweaks that improve the responsiveness of CTRL+C.

@TheTechromancer TheTechromancer self-assigned this Jul 24, 2024
Copy link

codecov bot commented Jul 28, 2024

Codecov Report

Attention: Patch coverage is 89.02439% with 18 lines in your changes missing coverage. Please review.

Project coverage is 93%. Comparing base (5753660) to head (ef368e2).
Report is 11 commits behind head on dev.

Files Patch % Lines
bbot/modules/output/neo4j.py 85% 10 Missing ⚠️
bbot/core/engine.py 83% 7 Missing ⚠️
bbot/scanner/manager.py 93% 1 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##             dev   #1582   +/-   ##
=====================================
- Coverage     93%     93%   -0%     
=====================================
  Files        347     339    -8     
  Lines      25482   25485    +3     
=====================================
- Hits       23548   23511   -37     
- Misses      1934    1974   +40     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TheTechromancer TheTechromancer changed the title Neo4j Update Update and Optimize Neo4j Jul 29, 2024
@TheTechromancer TheTechromancer merged commit f810f49 into dev Jul 30, 2024
8 checks passed
This was referenced Jul 30, 2024
@TheTechromancer TheTechromancer deleted the neo4j-update branch September 30, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants