Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'path' attribute for FINDING and VULNERABILITY #1656

Merged
merged 5 commits into from
Aug 16, 2024

Conversation

TheTechromancer
Copy link
Collaborator

@TheTechromancer TheTechromancer commented Aug 12, 2024

This PR adds a path attribute to FINDING and VULNERABILITY, and also allows these events to skip specifying a host. When no host is specified, it will automatically walk up the chain of parents and use the closest available one. This will be more convenient for modules that are raising FINDINGs from events without hosts, like FILESYSTEM.

In response to #1636.

Copy link

codecov bot commented Aug 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93%. Comparing base (4c9fbdf) to head (35a737b).
Report is 27 commits behind head on dev.

Additional details and impacted files
@@          Coverage Diff          @@
##             dev   #1656   +/-   ##
=====================================
+ Coverage     93%     93%   +1%     
=====================================
  Files        341     341           
  Lines      25807   25842   +35     
=====================================
+ Hits       23783   23819   +36     
+ Misses      2024    2023    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TheTechromancer TheTechromancer merged commit 9250fa5 into dev Aug 16, 2024
8 checks passed
@TheTechromancer TheTechromancer deleted the closest-host-option branch October 28, 2024 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants