Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better host inheritance #1666

Merged
merged 1 commit into from
Aug 17, 2024
Merged

Better host inheritance #1666

merged 1 commit into from
Aug 17, 2024

Conversation

TheTechromancer
Copy link
Collaborator

@TheTechromancer TheTechromancer commented Aug 16, 2024

FINDING and VULNERABILITY will now inherit their host, path, and url attributes from their parents if they aren't specified.

Addresses #1636.

@TheTechromancer TheTechromancer self-assigned this Aug 16, 2024
@TheTechromancer TheTechromancer changed the title better host inheritance Better host inheritance Aug 16, 2024
This was referenced Aug 16, 2024
Copy link

codecov bot commented Aug 16, 2024

Codecov Report

Attention: Patch coverage is 92.50000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 93%. Comparing base (3172528) to head (e735daa).
Report is 30 commits behind head on dev.

Files Patch % Lines
bbot/core/event/base.py 92% 2 Missing ⚠️
bbot/core/engine.py 0% 1 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##             dev   #1666   +/-   ##
=====================================
+ Coverage     93%     93%   +1%     
=====================================
  Files        341     341           
  Lines      25926   25932    +6     
=====================================
+ Hits       23893   23906   +13     
+ Misses      2033    2026    -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TheTechromancer TheTechromancer merged commit 92dc6a5 into dev Aug 17, 2024
8 checks passed
@TheTechromancer TheTechromancer deleted the better-host-inheritance branch October 28, 2024 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant