Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix httpx memory leak #1667

Merged
merged 2 commits into from
Aug 16, 2024
Merged

Fix httpx memory leak #1667

merged 2 commits into from
Aug 16, 2024

Conversation

TheTechromancer
Copy link
Collaborator

@TheTechromancer TheTechromancer commented Aug 16, 2024

Fixes #1615, a bug where multiple httpx clients were being created but not destroyed.

@TheTechromancer TheTechromancer self-assigned this Aug 16, 2024
This was referenced Aug 16, 2024
Copy link

codecov bot commented Aug 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93%. Comparing base (3172528) to head (aa1e93c).
Report is 3 commits behind head on dev.

Additional details and impacted files
@@          Coverage Diff          @@
##             dev   #1667   +/-   ##
=====================================
+ Coverage     93%     93%   +1%     
=====================================
  Files        341     341           
  Lines      25926   25934    +8     
=====================================
+ Hits       23893   23926   +33     
+ Misses      2033    2008   -25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TheTechromancer TheTechromancer merged commit ac08e5f into dev Aug 16, 2024
8 checks passed
@TheTechromancer TheTechromancer deleted the fix-httpx-memory-leak branch October 28, 2024 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants