optimize generate_templist #1696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #1696 +/- ##
=====================================
+ Coverage 93% 93% +1%
=====================================
Files 341 341
Lines 26039 26044 +5
=====================================
+ Hits 24010 24015 +5
Misses 2029 2029 ☔ View full report in Codecov by Sentry. |
bbot/modules/deadly/ffuf.py
Outdated
| prefix = prefix.strip().lower() | ||
|
|
||
| max_lines = self.config.get("lines") | ||
| banned_set = set(self.banned_characters) |
There was a problem hiding this comment.
since these are global to the module can we move them into setup()
There was a problem hiding this comment.
0e33cd9 Should be cleaner.
I didn't move it to setup(), because ffuf_shortnames overrides the ffuf setup() - keeping them as a class attribute is currently the least redundant way to define them.
TheTechromancer
approved these changes
Aug 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimizing ffuf generate_templist function