Revert "Merge pull request #1836 from domwhewell-sage/folder_crawling" #1917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheTechromancer
approved these changes
Nov 4, 2024
TheTechromancer
merged commit 3c2d05b
into
blacklanternsecurity:dev
13 of 14 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned on discord, the folder crawling functionality where speculate would re-raise each file within a folder as a new event was increasing the scan time significantly (When downloading folders such as git repositories)
This PR removes that functionality, for now, as we implement a different faster method of unpacking folders and running excavate over them to extract useful information