-
Notifications
You must be signed in to change notification settings - Fork 561
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Multiprocessing Shenanigans #1955
Conversation
b00e9ce
to
4a597e1
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #1955 +/- ##
======================================
- Coverage 93% 93% -0%
======================================
Files 363 366 +3
Lines 27845 27958 +113
======================================
+ Hits 25668 25757 +89
- Misses 2177 2201 +24 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
2e2473f
to
1ce31f4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved. All tests passed.
Addresses #1904.
This PR introduces better PID tracking to avoid multiprocessing mishaps, and adds a test to make sure BBOT can be used inside a fastapi endpoint.