Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Multiprocessing Shenanigans #1955

Merged
merged 8 commits into from
Nov 18, 2024
Merged

Fix Multiprocessing Shenanigans #1955

merged 8 commits into from
Nov 18, 2024

Conversation

TheTechromancer
Copy link
Collaborator

@TheTechromancer TheTechromancer commented Nov 13, 2024

Addresses #1904.

This PR introduces better PID tracking to avoid multiprocessing mishaps, and adds a test to make sure BBOT can be used inside a fastapi endpoint.

Copy link

codecov bot commented Nov 13, 2024

Codecov Report

Attention: Patch coverage is 86.46617% with 18 lines in your changes missing coverage. Please review.

Project coverage is 93%. Comparing base (09f7ec3) to head (53e9084).
Report is 30 commits behind head on dev.

Files with missing lines Patch % Lines
bbot/core/multiprocess.py 85% 6 Missing ⚠️
bbot/core/helpers/command.py 0% 4 Missing ⚠️
bbot/test/fastapi_test.py 67% 4 Missing ⚠️
bbot/core/core.py 75% 3 Missing ⚠️
bbot/test/test_step_1/test_bbot_fastapi.py 99% 1 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##             dev   #1955    +/-   ##
======================================
- Coverage     93%     93%    -0%     
======================================
  Files        363     366     +3     
  Lines      27845   27958   +113     
======================================
+ Hits       25668   25757    +89     
- Misses      2177    2201    +24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link
Contributor

@aconite33 aconite33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. All tests passed.

@TheTechromancer TheTechromancer merged commit b0e5bc9 into dev Nov 18, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants