-
Notifications
You must be signed in to change notification settings - Fork 561
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dnsbimi module, resolve #1625 #1965
Add dnsbimi module, resolve #1625 #1965
Conversation
…y/dev Dev --> Stable (2.1.0)
…y/dev Dev -> Stable 2.1.1
…y/dev Dev --> Stable 2.1.2
bbot/modules/dnsbimi.py
Outdated
|
||
for selector in self._selectors: | ||
tags = ["bimi-record", f"bimi-{selector}"] | ||
hostname = f"{selector}._bimi.{domain}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we are deduping by parent domain, this should probably also be set to the parent.
bbot/modules/dnsbimi.py
Outdated
import re | ||
|
||
|
||
bimi_common_selectors = ["default", "email", "mail", "bimi"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The default selectors should be in the default config, as an example for how to format the option. E.g.:
options = {
"emit_raw_dns_records": False,
"emit_urls": True,
"selectors": "default,email,mail,bimi",
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeap, fair, will add additional commit with this.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #1965 +/- ##
=======================================
- Coverage 93% 93% -0%
=======================================
Files 341 365 +24
Lines 25772 27914 +2142
=======================================
+ Hits 23788 25706 +1918
- Misses 1984 2208 +224 ☔ View full report in Codecov by Sentry. |
This PR adds a new module
dnsbimi
which inspects BIMI records for a default, or custom, set of BIMI selector DNS records which may exist under a target domain.Refer to #1625 for more info about BIMI.