Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dnsbimi module, resolve #1625 #1965

Merged
merged 8 commits into from
Nov 16, 2024

Conversation

colin-stubbs
Copy link
Contributor

@colin-stubbs colin-stubbs commented Nov 15, 2024

This PR adds a new module dnsbimi which inspects BIMI records for a default, or custom, set of BIMI selector DNS records which may exist under a target domain.

Refer to #1625 for more info about BIMI.

@TheTechromancer TheTechromancer changed the base branch from stable to dev November 15, 2024 14:37

for selector in self._selectors:
tags = ["bimi-record", f"bimi-{selector}"]
hostname = f"{selector}._bimi.{domain}"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we are deduping by parent domain, this should probably also be set to the parent.

import re


bimi_common_selectors = ["default", "email", "mail", "bimi"]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default selectors should be in the default config, as an example for how to format the option. E.g.:

    options = {
        "emit_raw_dns_records": False,
        "emit_urls": True,
        "selectors": "default,email,mail,bimi",
    }

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeap, fair, will add additional commit with this.

Copy link

codecov bot commented Nov 16, 2024

Codecov Report

Attention: Patch coverage is 90.17288% with 324 lines in your changes missing coverage. Please review.

Project coverage is 93%. Comparing base (db565b4) to head (796d633).
Report is 771 commits behind head on dev.

Files with missing lines Patch % Lines
bbot/core/helpers/depsinstaller/sudo_askpass.py 0% 29 Missing ⚠️
bbot/modules/subdomainradar.py 77% 27 Missing ⚠️
bbot/modules/trufflehog.py 58% 27 Missing ⚠️
bbot/modules/postman_download.py 88% 21 Missing ⚠️
bbot/core/helpers/depsinstaller/installer.py 56% 19 Missing ⚠️
bbot/core/engine.py 88% 18 Missing ⚠️
bbot/core/config/logger.py 15% 17 Missing ⚠️
bbot/modules/internal/excavate.py 85% 16 Missing ⚠️
bbot/modules/github_workflows.py 75% 13 Missing ⚠️
bbot/modules/google_playstore.py 79% 13 Missing ⚠️
... and 28 more
Additional details and impacted files
@@           Coverage Diff           @@
##             dev   #1965     +/-   ##
=======================================
- Coverage     93%     93%     -0%     
=======================================
  Files        341     365     +24     
  Lines      25772   27914   +2142     
=======================================
+ Hits       23788   25706   +1918     
- Misses      1984    2208    +224     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TheTechromancer TheTechromancer merged commit be2a005 into blacklanternsecurity:dev Nov 16, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants