Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc bugfixes #2086

Merged
merged 3 commits into from
Dec 17, 2024
Merged

Misc bugfixes #2086

merged 3 commits into from
Dec 17, 2024

Conversation

TheTechromancer
Copy link
Collaborator

@TheTechromancer TheTechromancer commented Dec 17, 2024

Fixes:

Adds a test for the above bug and also tweaks the final "scan completed" message to always be printed on the very last line of output.

Copy link

codecov bot commented Dec 17, 2024

Codecov Report

Attention: Patch coverage is 89.47368% with 2 lines in your changes missing coverage. Please review.

Project coverage is 93%. Comparing base (05110e4) to head (9f50136).
Report is 6 commits behind head on dev.

Files with missing lines Patch % Lines
bbot/scanner/scanner.py 80% 2 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##             dev   #2086   +/-   ##
=====================================
- Coverage     93%     93%   -0%     
=====================================
  Files        376     376           
  Lines      28672   28679    +7     
=====================================
- Hits       26461   26452    -9     
- Misses      2211    2227   +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TheTechromancer TheTechromancer changed the title misc bugfixes Misc bugfixes Dec 17, 2024
@TheTechromancer TheTechromancer merged commit 5bd7682 into dev Dec 17, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants