Replace secretsdb with trufflehog #2092
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trufflehog has become the defacto secrets module in BBOT. Since secretsdb tends to hog CPU by using old fashioned python regexes, it's high time it was replaced.
The key step here was modifying Trufflehog to accept
HTTP_RESPONSE
events. Trufflehog doesn't yet support stdin mode, so it currently uses thefilesystem
module. (see trufflesecurity/trufflehog#162).FYSA @domwhewell-sage. What do you think of also including
RAW_TEXT
?