Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues with mailto links and parameter extraction #2104

Merged
merged 5 commits into from
Dec 20, 2024

Conversation

liquidsec
Copy link
Collaborator

partially addresses

#2101

and #1860

@liquidsec liquidsec changed the title fixing issues with mailto links and parameter extraction Fix issues with mailto links and parameter extraction Dec 19, 2024
Copy link

codecov bot commented Dec 19, 2024

Codecov Report

Attention: Patch coverage is 91.30435% with 2 lines in your changes missing coverage. Please review.

Project coverage is 93%. Comparing base (42eebcd) to head (22773f7).
Report is 13 commits behind head on dev.

Files with missing lines Patch % Lines
bbot/modules/internal/excavate.py 50% 2 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##             dev   #2104   +/-   ##
=====================================
+ Coverage     93%     93%   +1%     
=====================================
  Files        376     376           
  Lines      28689   28758   +69     
=====================================
+ Hits       26483   26550   +67     
- Misses      2206    2208    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ausmaster ausmaster self-requested a review December 19, 2024 19:48
Copy link
Collaborator

@ausmaster ausmaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested yesterday, looks good.

@TheTechromancer TheTechromancer merged commit 798670d into dev Dec 20, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants