Rename output.json to output.ndjson #735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change output.json to output.ndjson, and update the output text to the end user for clarification.
Update docs to reflect .ndjson file change
Updating to .ndjson
Updating for output.ndjson change
Updating for ndjson filename use.
Update filename to make use of ndjson extension.
|
LGTM! |
TheTechromancer
approved these changes
Sep 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To better align with the actual file type of BBOT which is NDJSON, I would suggest that we name the file with the .ndjson extension, not to confuse end users of what is actually contained in output.json.
Discussion here: #734
It appears that there is at least one documentation image that needs to be updated to reflect the new .ndjson file name if this is something that is being seriously considered.
That image is here:
bbot/docs/scanning/output.md
Line 4 in 97b2c31