excavate CSP submodule #783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #783 +/- ##
=====================================
+ Coverage 92% 92% +1%
=====================================
Files 291 291
Lines 17173 17205 +32
=====================================
+ Hits 15674 15716 +42
+ Misses 1499 1489 -10
... and 9 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
bbot/modules/internal/excavate.py
Outdated
| self.report(domain, event, **kwargs) | ||
|
|
||
| def report(self, domain, event, **kwargs): | ||
| self.excavate.emit_event(domain, "DNS_NAME_UNRESOLVED", source=event) |
There was a problem hiding this comment.
Instead of emitting as DNS_NAME_UNRESOLVED I would emit as a DNS_NAME with tags=["affiliate"].
Merged
TheTechromancer
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference: #711
This will allow excavate to harvest domains from CSP headers. This could be an excellent source of subdomains or related (affiliate) domains.