Discover Common On-Prem Microsoft Stuff (RDP, ADFS, OWA, etc.) #790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 17, 2023
Merged
TheTechromancer
force-pushed
the
ms-on-prem-subdomains
branch
from
63cc295 to
d02e19a
Compare
TheTechromancer
force-pushed
the
ms-on-prem-subdomains
branch
from
d02e19a to
1655bc7
Compare
TheTechromancer
force-pushed
the
ms-on-prem-subdomains
branch
from
1519780 to
ca89535
Compare
Codecov Report
@@ Coverage Diff @@
## dev #790 +/- ##
=====================================
+ Coverage 92% 92% +1%
=====================================
Files 291 291
Lines 17173 17178 +5
=====================================
+ Hits 15674 15691 +17
+ Misses 1499 1487 -12
... and 6 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
liquidsec
approved these changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a 100-line wordlist to massdns that ensures we're looking for common microsoft on-prem services like RDP, ADFS, and OWA. The wordlist was taken from msprobe.
Note: this PR also changes modules' setup to hard-fail if their wordlist fails to download.
Addresses #789.