-
Notifications
You must be signed in to change notification settings - Fork 561
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Created module for enumerating AWS S3 Bucket files. #806
Conversation
Need to see about changing emit to a URL so other modules can consume the URL for the file(s) discovered |
I would add a meta description similar to: That will show up on the front end. For the produced events, it seems the other bucket modules use "STORAGE_BUCKET" and "FINDING". I don't think I have anything handling "BUCKET_FILE" right now but if that's just something new I can add it. It won't break anything on my end. |
2fa6c63
to
be4c695
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev #806 +/- ##
=====================================
+ Coverage 92% 92% +1%
=====================================
Files 287 289 +2
Lines 17899 17956 +57
=====================================
+ Hits 16458 16516 +58
+ Misses 1441 1440 -1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need a file count limit and either a blacklist or whitelist for file types
2b30751
to
dcf6ef5
Compare
dcf6ef5
to
12ce177
Compare
Tests have been written and the module has been integrated with |
This module will emit files that are listed in an S3 AWS Bucket