Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created module for enumerating AWS S3 Bucket files. #806

Merged
merged 9 commits into from
Nov 20, 2023
Merged

Conversation

aconite33
Copy link
Contributor

This module will emit files that are listed in an S3 AWS Bucket

@aconite33
Copy link
Contributor Author

Need to see about changing emit to a URL so other modules can consume the URL for the file(s) discovered

@aconite33 aconite33 requested review from batgoose and TheTechromancer and removed request for TheTechromancer October 27, 2023 15:09
@batgoose
Copy link
Contributor

I would add a meta description similar to:
meta = {"description": "Check for _____ related to target"}

That will show up on the front end.

For the produced events, it seems the other bucket modules use "STORAGE_BUCKET" and "FINDING". I don't think I have anything handling "BUCKET_FILE" right now but if that's just something new I can add it. It won't break anything on my end.

@TheTechromancer TheTechromancer force-pushed the s3_bucket_enum branch 3 times, most recently from 2fa6c63 to be4c695 Compare November 13, 2023 21:49
Copy link

codecov bot commented Nov 14, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (ce66a46) 92% compared to head (f67a5ce) 92%.
Report is 6 commits behind head on dev.

Files Patch % Lines
bbot/modules/bucket_file_enum.py 98% 1 Missing ⚠️
bbot/modules/filedownload.py 88% 1 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##             dev    #806   +/-   ##
=====================================
+ Coverage     92%     92%   +1%     
=====================================
  Files        287     289    +2     
  Lines      17899   17956   +57     
=====================================
+ Hits       16458   16516   +58     
+ Misses      1441    1440    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@liquidsec liquidsec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need a file count limit and either a blacklist or whitelist for file types

@TheTechromancer TheTechromancer force-pushed the s3_bucket_enum branch 2 times, most recently from 2b30751 to dcf6ef5 Compare November 16, 2023 20:34
@TheTechromancer
Copy link
Collaborator

Tests have been written and the module has been integrated with filedownload. Several other small changes were needed relating to URL validation.

@aconite33 aconite33 merged commit 6489831 into dev Nov 20, 2023
8 checks passed
@TheTechromancer TheTechromancer deleted the s3_bucket_enum branch December 15, 2023 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants