Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discord Content Length Bugfix #862

Merged
merged 7 commits into from
Nov 27, 2023
Merged

Discord Content Length Bugfix #862

merged 7 commits into from
Nov 27, 2023

Conversation

TheTechromancer
Copy link
Collaborator

@TheTechromancer TheTechromancer commented Nov 24, 2023

Fixes #861.

Also consolidates the discord, teams, and slack output modules to inherit from a new webhook template.

Copy link

codecov bot commented Nov 24, 2023

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (831fa11) 92% compared to head (32572ef) 92%.

Files Patch % Lines
bbot/modules/templates/webhook.py 89% 8 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##             dev    #862   +/-   ##
=====================================
- Coverage     92%     92%   -0%     
=====================================
  Files        289     290    +1     
  Lines      17951   17958    +7     
=====================================
- Hits       16506   16503    -3     
- Misses      1445    1455   +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TheTechromancer TheTechromancer linked an issue Nov 24, 2023 that may be closed by this pull request
@TheTechromancer TheTechromancer merged commit dd6e123 into dev Nov 27, 2023
8 checks passed
@TheTechromancer TheTechromancer deleted the discord-bugfix branch December 15, 2023 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Discord output module hangs on longer messages
2 participants