Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Portscanner Rework #886

Merged
merged 16 commits into from
Dec 23, 2023
Merged

Portscanner Rework #886

merged 16 commits into from
Dec 23, 2023

Conversation

TheTechromancer
Copy link
Collaborator

@TheTechromancer TheTechromancer commented Nov 29, 2023

This PR updates the nmap module to accept IP_RANGEs, which resolves this issue.

Included in this PR are several other improvements to BBOT's port scanners nmap and masscan, including better blacklist support for nmap and the ability for masscan to accept individual IPs as targets.

I also want to add hostname support for masscan, but this turned out to be more work than I anticipated, so this feature will be part of a later PR.

@TheTechromancer TheTechromancer self-assigned this Nov 29, 2023
@TheTechromancer TheTechromancer linked an issue Nov 29, 2023 that may be closed by this pull request
@TheTechromancer TheTechromancer changed the base branch from stable to dev November 29, 2023 22:23
Copy link

codecov bot commented Nov 29, 2023

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (8137736) 92% compared to head (d4a9e0e) 93%.
Report is 8 commits behind head on dev.

Files Patch % Lines
bbot/modules/masscan.py 91% 3 Missing ⚠️
bbot/modules/templates/portscanner.py 94% 2 Missing ⚠️
bbot/modules/base.py 84% 1 Missing ⚠️
bbot/modules/internal/speculate.py 90% 1 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##             dev    #886   +/-   ##
=====================================
+ Coverage     92%     93%   +1%     
=====================================
  Files        292     295    +3     
  Lines      18134   18217   +83     
=====================================
+ Hits       16677   16771   +94     
+ Misses      1457    1446   -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TheTechromancer
Copy link
Collaborator Author

This needs to be made optional to preserve the use_previous functionality with asset_inventory.

@TheTechromancer TheTechromancer linked an issue Dec 19, 2023 that may be closed by this pull request
@TheTechromancer TheTechromancer linked an issue Dec 19, 2023 that may be closed by this pull request
@TheTechromancer TheTechromancer removed a link to an issue Dec 20, 2023
@TheTechromancer TheTechromancer changed the title Nmap: Accept IP_RANGES Portscanner Rework Dec 20, 2023
@TheTechromancer TheTechromancer linked an issue Dec 20, 2023 that may be closed by this pull request
@TheTechromancer TheTechromancer merged commit b06dc37 into dev Dec 23, 2023
8 checks passed
@TheTechromancer TheTechromancer deleted the nmap-accept-ip-range branch March 7, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants