-
Notifications
You must be signed in to change notification settings - Fork 561
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Portscanner Rework #886
Merged
Merged
Portscanner Rework #886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev #886 +/- ##
=====================================
+ Coverage 92% 93% +1%
=====================================
Files 292 295 +3
Lines 18134 18217 +83
=====================================
+ Hits 16677 16771 +94
+ Misses 1457 1446 -11 ☔ View full report in Codecov by Sentry. |
This needs to be made optional to preserve the |
TheTechromancer
force-pushed
the
nmap-accept-ip-range
branch
from
December 15, 2023 19:40
541eef8
to
9a56ac8
Compare
This was
linked to
issues
Dec 15, 2023
Closed
Closed
Closed
Closed
Closed
This was referenced Dec 20, 2023
Closed
liquidsec
approved these changes
Dec 20, 2023
batgoose
approved these changes
Dec 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the nmap module to accept IP_RANGEs, which resolves this issue.
Included in this PR are several other improvements to BBOT's port scanners nmap and masscan, including better blacklist support for nmap and the ability for masscan to accept individual IPs as targets.
I also want to add hostname support for masscan, but this turned out to be more work than I anticipated, so this feature will be part of a later PR.