Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detailed description
Load failed
for STM32F7 binaries linked to 0x0200_0000 ITCM flash bigger than 64 KiB.Tested on STM32F722RE with BMDA/
blackpill-f411ce
to allow loading 512 KiB binaries (erase, write, verify, in-firmware check). Testers with F76x/F77x (like STM32F777) are otherwise welcome.I've changed the order of first bank
stm32f4_add_flash()
calls here, maybe it's unwanted. But the following code block will also want to append to ITCM dual-bank sectors. If mixed order in-BMP is a problem, please state so. Another worry is this will interact with futureblank_check
feature, forcing it to walk entire NVM twice. I'd like to treat this separately by tracking e.g. some "is-alias" flag, also applicable to OTP pages (of G0).Like in PR2075, please clarify whether refman references are mandatory there or here.
Your checklist for this pull request
Closing issues
Closes #2006.