Core: vector symbols and expressions #971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blackyblack
reviewed
Mar 4, 2025
| raise TypeError(f"Norm {norm} must be an Expr, got {type(norm).__name__}.") | ||
|
|
||
| try: | ||
| is_non_negative = bool(norm >= 0) |
There was a problem hiding this comment.
Why not use is_negative flag?
There was a problem hiding this comment.
I opted in for ask(Q.negative(...)) in the end. Is .is_negative defined on all expressions?
blackyblack
reviewed
Mar 5, 2025
blackyblack
reviewed
Mar 5, 2025
| if isinstance(value, (Add, Mul)): | ||
| # NOTE: `p` is not needed for `_needs_mul_brackets`, we could refactor it out of the | ||
| # `SymbolCodePrinter` class. | ||
| if SymbolCodePrinter._needs_mul_brackets(p, value, last=True): |
There was a problem hiding this comment.
Eventually I'd like to have this helper method extracted somewhere. Pylint will warn about using protected method here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.