Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch core functionality #972

Merged
merged 11 commits into from
Mar 6, 2025
Merged

Patch core functionality #972

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
c827a62
Fix SI conversion and add docstrings
alesanter Mar 4, 2025
0cbd37f
Fix pylint
alesanter Mar 4, 2025
f03cf86
Refactor dimensions and split big modules
alesanter Mar 4, 2025
d696991
Fix types and remove aliases
alesanter Mar 4, 2025
13c9f03
Add quantity string repr
alesanter Mar 4, 2025
a1517f9
Fix quantity string repr
alesanter Mar 4, 2025
0b38bdf
Fix more types
alesanter Mar 5, 2025
2908263
Refine types
alesanter Mar 5, 2025
09f903b
Merge branch 'master' into patch-core-1
alesanter Mar 5, 2025
bbda700
Add mypy fixes
alesanter Mar 5, 2025
b44eb96
Add fixes
alesanter Mar 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion symplyphysics/core/experimental/vectors/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -380,7 +380,7 @@ def filter_scales(mapping: dict[VectorExpr, Expr]) -> dict[VectorExpr, Expr]:

mapping = filter_scales(collect_scales(flatten_additions(self.args)))

scaled_addends = [vector * scale for vector, scale in mapping.items()]
scaled_addends: list[VectorExpr] = [vector * scale for vector, scale in mapping.items()]

match len(scaled_addends):
case 0:
Expand Down
3 changes: 2 additions & 1 deletion test/core/experimental/vectors/test_vector.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,8 @@ def test_init() -> None:
VectorSymbol(name, dim, norm=symbols.force, display_latex=latex)

one_newton_force = VectorSymbol(name, dim, norm=1 * units.newton, display_latex=latex)
assert_equal(one_newton_force.norm, 1 * units.newton)
if one_newton_force.norm: # mypy complains otherwise
assert_equal(one_newton_force.norm, 1 * units.newton)
assert not one_newton_force.is_zero

assert VectorSymbol("a", norm=0) is ZERO
Expand Down