Multi-format support #1205

pablo-mayrgundter · 2024-06-01T18:31:12Z

Demos:

Loader Changes

Move loading logic out of CadView into src/loader/Loader.js
Most hardcoding of .ifc is removed
Temp UUID Urls now have type suffix when possible
Combined loader alg:
1. Check for uploaded file
2. Dereference paths or GH Urls as needed e.g. for proxy
3. Content sniff for loader type (for multi-format support)
4. Download model to OPFS if available
5. Parse with format-specific loader
6. Convert to IFC-like object model, to support basic picking and nav support
7. Add to scene

Misc

Alert, AlertDialog, SnackBar: refactored to surface custom error messages better
navigate helper: avoid passing around when they can be imported
window.{add,remove}EventListener('beforeunload', handleBeforeUnload) -> imported helper
safePathSplit helper instead of path.split('/')
eslint: allow warn and error logging

netlify · 2024-06-01T18:31:15Z

✅ Deploy Preview for bldrs-share ready!

Name	Link
🔨 Latest commit	`d4dccc3`
🔍 Latest deploy log	https://app.netlify.com/sites/bldrs-share/deploys/6741c461cea4470008131580
😎 Deploy Preview	https://deploy-preview-1205--bldrs-share.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 17 (no change from production) Accessibility: 89 (no change from production) Best Practices: 92 (no change from production) SEO: 100 (no change from production) PWA: - View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify · 2024-08-09T22:18:40Z

✅ Deploy Preview for bldrs-share-prod ready!

Name	Link
🔨 Latest commit	`d4dccc3`
🔍 Latest deploy log	https://app.netlify.com/sites/bldrs-share-prod/deploys/6741c4619b7e13000845508f
😎 Deploy Preview	https://deploy-preview-1205--bldrs-share-prod.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

…der: add base URL support. AboutDialog: refactor

public/models

public/lsd.pdb

pablo-mayrgundter · 2024-11-14T13:56:06Z

src/Infrastructure/IfcIsolator.js

@@ -58,7 +58,11 @@ export default class IfcIsolator {
   */
  async setModel(ifcModel) {
    this.ifcModel = ifcModel
-    this.visualElementsIds = [...new Set(ifcModel.geometry.attributes.expressID.array)]
+    if (ifcModel.geometry && ifcModel.geometry.attributes) {


Review carefully

src/Infrastructure/IfcViewerAPIExtended.js

yarn.lock

pablo-mayrgundter · 2024-11-20T23:16:36Z

src/Containers/CadView.jsx

-    const item = await viewer.castRayToIfcScene()
-    if (!item) {
-      return
+  function canvasDoubleClickHandler(event) {


Review carefully

pablo-mayrgundter · 2024-11-20T23:18:35Z

src/Containers/urls.js

@@ -12,7 +12,7 @@ export async function getFinalUrl(url, accessToken) {
  switch (u.host.toLowerCase()) {
    case 'github.com':
      if (!accessToken) {
-        const proxyUrl = new URL(process.env.RAW_GIT_PROXY_URL_NEW)
+        const proxyUrl = new URL(process.env.RAW_GIT_PROXY_URL)


This looks wrong.. no accessToken should use the new /model base on proxy url i think

pablo-mayrgundter · 2024-11-20T23:23:30Z

src/OPFS/OPFS.worker.js

-      }
-    } catch (error) {
-      // expected if file not found - lets see if we have a temporary file
+      } else {


Nick, this was the fallthru we fixed together. pls double-check i got the edit right

pablo-mayrgundter · 2024-11-20T23:27:17Z

src/loader/Loader.js

Please review carefully

….cypress.js

pablo-mayrgundter added 3 commits May 31, 2024 19:23

CadView: hoist progress handler

15d0849

CadView: in loadIfc separate opfs load and from ifc load

1e284f9

formats: add initial support for bld, fbx, glb, ifc, obj, pdb

887bac3

pablo-mayrgundter added the enhancement New feature or request label Jun 1, 2024

pablo-mayrgundter added this to the Open 200: Multi-format support milestone Jun 1, 2024

pablo-mayrgundter requested a review from nickcastel50 June 1, 2024 18:31

pablo-mayrgundter self-assigned this Jun 1, 2024

pablo-mayrgundter had a problem deploying to cypress June 1, 2024 18:31 — with GitHub Actions Failure

pdb: picking working

0a3c2b6

pablo-mayrgundter had a problem deploying to cypress June 3, 2024 00:14 — with GitHub Actions Failure

pablo-mayrgundter added 4 commits June 7, 2024 14:48

Checkpoint

9734b9d

Checkpoint

94d9926

Checkpoint

4d2f995

drag n drop working for all formats

52d7357

pablo-mayrgundter had a problem deploying to cypress August 9, 2024 22:17 — with GitHub Actions Failure

pablo-mayrgundter added 6 commits October 2, 2024 18:39

checkpoint

0a47d68

CadView: Better specialized exception handling in load errors. BLDLoa…

72a8b0e

…der: add base URL support. AboutDialog: refactor

checkpoint to force build

27629d1

checkpoint to force build, remove model symlink

e156333

merge checkpoint: dnd working for all filetypes, still working on opfs

1a4f1e1

checkpoint. full bld model loading and want to diff in gh

c3c2086

pablo-mayrgundter had a problem deploying to cypress November 14, 2024 13:52 — with GitHub Actions Failure

pablo-mayrgundter commented Nov 14, 2024

View reviewed changes

public/models Outdated Show resolved Hide resolved

pablo-mayrgundter commented Nov 14, 2024

View reviewed changes

public/lsd.pdb Outdated Show resolved Hide resolved

pablo-mayrgundter commented Nov 14, 2024

View reviewed changes

src/Infrastructure/IfcViewerAPIExtended.js Outdated Show resolved Hide resolved

pablo-mayrgundter commented Nov 14, 2024

View reviewed changes

yarn.lock Show resolved Hide resolved

checkpoint. ifc nav and sections working post-merge.

24ddc01

pablo-mayrgundter had a problem deploying to cypress November 20, 2024 23:00 — with GitHub Actions Failure

pablo-mayrgundter marked this pull request as ready for review November 20, 2024 23:01

pablo-mayrgundter commented Nov 20, 2024

View reviewed changes

pablo-mayrgundter had a problem deploying to cypress November 21, 2024 00:00 — with GitHub Actions Failure

Open: use TextField instead of SearchBar for GitHub URL entry.

7640e62

pablo-mayrgundter had a problem deploying to cypress November 21, 2024 10:10 — with GitHub Actions Failure

cypress: test fix for GHA, possible proxy URL diff

88ad277

pablo-mayrgundter had a problem deploying to cypress November 21, 2024 11:08 — with GitHub Actions Failure

cypress: second test fix for GHA

6d5076b

pablo-mayrgundter had a problem deploying to cypress November 21, 2024 12:05 — with GitHub Actions Error

gha: set RAW_GIT_PROXY_URL in cypress env to match tools/esbuild/vars…

5898b1c

….cypress.js

pablo-mayrgundter had a problem deploying to cypress November 21, 2024 12:16 — with GitHub Actions Error

pablo-mayrgundter added 2 commits November 21, 2024 13:37

gha: better logging for GHA proxy debugging

91038f3

gha: fix gha config

955af24

pablo-mayrgundter had a problem deploying to cypress November 21, 2024 12:39 — with GitHub Actions Failure

pablo-mayrgundter added 4 commits November 22, 2024 00:47

cypress: lots of refactoring to allow env var configuration from cypress

18311ee

Tests pass

1f75154

cypress.config: all cy vars

6a0b583

merge and test

f12b5e6

pablo-mayrgundter had a problem deploying to cypress November 22, 2024 01:22 — with GitHub Actions Failure

lint fix

e7a0ff8

pablo-mayrgundter had a problem deploying to cypress November 22, 2024 01:26 — with GitHub Actions Failure

lint fix

25e9a5f

pablo-mayrgundter had a problem deploying to cypress November 22, 2024 01:27 — with GitHub Actions Failure

merge and test

52c7ea0

pablo-mayrgundter had a problem deploying to cypress November 23, 2024 11:46 — with GitHub Actions Failure

Merge branch 'main' into multi-format

d4dccc3

pablo-mayrgundter merged commit 69888d8 into bldrs-ai:main Nov 23, 2024
1 of 2 checks passed

pablo-mayrgundter had a problem deploying to cypress November 23, 2024 12:03 — with GitHub Actions Failure

pablo-mayrgundter mentioned this pull request Nov 23, 2024

AEC Hackathon - Munich cypress test skips #1269

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Multi-format support #1205

Multi-format support #1205

pablo-mayrgundter commented Jun 1, 2024 •

edited

Loading

netlify bot commented Jun 1, 2024 •

edited

Loading

netlify bot commented Aug 9, 2024 •

edited

Loading

pablo-mayrgundter Nov 14, 2024

pablo-mayrgundter Nov 20, 2024

pablo-mayrgundter Nov 20, 2024

pablo-mayrgundter Nov 20, 2024

pablo-mayrgundter Nov 20, 2024

Multi-format support #1205

Multi-format support #1205

Conversation

pablo-mayrgundter commented Jun 1, 2024 • edited Loading

Loader Changes

Misc

netlify bot commented Jun 1, 2024 • edited Loading

✅ Deploy Preview for bldrs-share ready!

netlify bot commented Aug 9, 2024 • edited Loading

✅ Deploy Preview for bldrs-share-prod ready!

pablo-mayrgundter Nov 14, 2024

Choose a reason for hiding this comment

pablo-mayrgundter Nov 20, 2024

Choose a reason for hiding this comment

pablo-mayrgundter Nov 20, 2024

Choose a reason for hiding this comment

pablo-mayrgundter Nov 20, 2024

Choose a reason for hiding this comment

pablo-mayrgundter Nov 20, 2024

Choose a reason for hiding this comment

pablo-mayrgundter commented Jun 1, 2024 •

edited

Loading

netlify bot commented Jun 1, 2024 •

edited

Loading

netlify bot commented Aug 9, 2024 •

edited

Loading