Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI Refresh: Apps, LeftDrawer, themed Typography, reorg; Hot-reload esbuild and more #1271

Merged
merged 19 commits into from
Dec 4, 2024

Conversation

pablo-mayrgundter
Copy link
Member

@pablo-mayrgundter pablo-mayrgundter commented Nov 30, 2024

Percy

Main updates:

  • AppsDrawer
  • LeftDrawer: NavTree & Versions now on left like Notes & Properties on right
  • Move most Component groups to Containers dir
  • Serve Roboto font (WIP)
  • More uniform use of data-testid
  • Typography from theme
  • Icons & Typography sized together

Tools

  • Hot reloading in dev
  • React StrictMode in dev

Broken in Percy:

  • Search 100: Permalink Returning user visits homepage, Open Search > Enters "together" Search box with query visible, "Together" items highlighted in tree and scene
  • Notes 100: Access shared note Returning user accessing permalink with notes panel open Notes open - Screen
  • view 100: Cutplanes View model Click CutPlaneControl Select all cut-planes Clear all cut-planes No cutplanes visible

Copy link

netlify bot commented Nov 30, 2024

Deploy Preview for bldrs-share ready!

Name Link
🔨 Latest commit 0819fc4
🔍 Latest deploy log https://app.netlify.com/sites/bldrs-share/deploys/6750d390f7f04d0007435c70
😎 Deploy Preview https://deploy-preview-1271--bldrs-share.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 0 (🔴 down 17 from production)
Accessibility: 89 (no change from production)
Best Practices: 92 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Signed-off-by: Pablo Mayrgundter <[email protected]>
Copy link

netlify bot commented Nov 30, 2024

Deploy Preview for bldrs-share-prod ready!

Name Link
🔨 Latest commit ccd5b0f
🔍 Latest deploy log https://app.netlify.com/sites/bldrs-share-prod/deploys/674b793376aec1000818bf44
😎 Deploy Preview https://deploy-preview-1271--bldrs-share-prod.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@pablo-mayrgundter pablo-mayrgundter changed the title UI Refresh, Apps, LeftDrawer UI Refresh: Apps, LeftDrawer, themed Typography, reorg; Hot-reload esbuild and more Nov 30, 2024
Copy link

netlify bot commented Nov 30, 2024

Deploy Preview for bldrs-share-prod ready!

Name Link
🔨 Latest commit 0819fc4
🔍 Latest deploy log https://app.netlify.com/sites/bldrs-share-prod/deploys/6750d3902da3500008a702d9
😎 Deploy Preview https://deploy-preview-1271--bldrs-share-prod.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@pablo-mayrgundter pablo-mayrgundter self-assigned this Dec 4, 2024
@pablo-mayrgundter pablo-mayrgundter added bug Something isn't working enhancement New feature or request labels Dec 4, 2024
@pablo-mayrgundter pablo-mayrgundter marked this pull request as ready for review December 4, 2024 21:44
Copy link
Contributor

@nickcastel50 nickcastel50 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pablo-mayrgundter pablo-mayrgundter merged commit 77f8aee into bldrs-ai:main Dec 4, 2024
10 checks passed
pablo-mayrgundter added a commit to pablo-mayrgundter/Share that referenced this pull request Dec 5, 2024
pablo-mayrgundter added a commit that referenced this pull request Dec 5, 2024
@pablo-mayrgundter pablo-mayrgundter deleted the app branch December 5, 2024 04:05
Copy link

sentry-io bot commented Dec 6, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ React ErrorBoundary Error: The operation is insecure. addHashParams(src/utils/location) View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants