Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WASM Build process optimization + web_ifc_native ifc types fix + updated for conway refactor #39

Merged
merged 4 commits into from
Jun 29, 2023
Merged

WASM Build process optimization + web_ifc_native ifc types fix + updated for conway refactor #39

merged 4 commits into from
Jun 29, 2023

Conversation

nickcastel50
Copy link
Contributor

@nickcastel50 nickcastel50 commented Jun 28, 2023 •
edited
Loading

References conway PR: 35

@nickcastel50 nickcastel50 self-assigned this Jun 28, 2023
@nickcastel50 nickcastel50 requested a review from oo-bldrs June 28, 2023 19:40
oo-bldrs
oo-bldrs approved these changes Jun 28, 2023
View reviewed changes
Copy link
Contributor

@oo-bldrs oo-bldrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nickcastel50 nickcastel50 changed the title WASM Build process optimization + web_ifc_native ifc types fix WASM Build process optimization + web_ifc_native ifc types fix + updated for conway refactor Jun 29, 2023
@nickcastel50 nickcastel50 requested a review from ConorStokes June 29, 2023 21:55
ConorStokes
ConorStokes approved these changes Jun 29, 2023
View reviewed changes
Copy link
Contributor

@ConorStokes ConorStokes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Pre-reviewed these changes during pairing.
  • This is a working build, but a work in progress vs the next issues, and we're running quick.

@ConorStokes ConorStokes merged commit cfdb138 into bldrs-ai:main Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ConorStokes ConorStokes ConorStokes approved these changes

@oo-bldrs oo-bldrs oo-bldrs approved these changes

Assignees

@nickcastel50 nickcastel50

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nickcastel50 @ConorStokes @oo-bldrs